[PATCH] [mips] Avoid redundant sign extension of the result of binary bitwise instructions.

Daniel Sanders daniel.sanders at imgtec.com
Wed Feb 18 06:27:23 PST 2015


LGTM with a comment nit.


================
Comment at: lib/Target/Mips/Mips64InstrInfo.td:489
@@ -488,1 +488,3 @@
 
+// bypass trunc nodes for bitwise ops
+def : MipsPat<(i32 (trunc (and GPR64:$lhs, GPR64:$rhs))),
----------------
Nit: Capitalize first letter and add full-stop

http://reviews.llvm.org/D7581

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list