[lld] r229453 - [Mips] Replace a magic number by enumeration

Jean-Daniel Dupas dev at xenonium.com
Wed Feb 18 05:56:15 PST 2015


Where that constant is supposed to be defined ? When building lld on OS X I have now a undeclared identifier ODK_REGINFO error.

> Le 17 févr. 2015 à 00:08, Simon Atanasyan <simon at atanasyan.com> a écrit :
> 
> Author: atanasyan
> Date: Mon Feb 16 17:08:20 2015
> New Revision: 229453
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=229453&view=rev
> Log:
> [Mips] Replace a magic number by enumeration
> 
> No functional changes.
> 
> Modified:
>    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFFile.h
> 
> Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFFile.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFFile.h?rev=229453&r1=229452&r2=229453&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFFile.h (original)
> +++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFFile.h Mon Feb 16 17:08:20 2015
> @@ -178,7 +178,7 @@ private:
>               StringRef("Invalid size of MIPS_OPTIONS section"));
> 
>         const auto *opt = reinterpret_cast<const Elf_Mips_Options *>(raw.data());
> -        if (opt->kind == 1/*ODK_REGINFO*/) {
> +        if (opt->kind == ODK_REGINFO) {
>           _gp0 = reinterpret_cast<const Elf_RegInfo *>(opt + 1)->ri_gp_value;
>           break;
>         }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list