[llvm] r229584 - We require MSVC 2013 Update 4 due to previous versions miscompiling ASTMatchers

[Kaylor, Andrew]

This is a fairly painful change for me.

I didn't really mind the idea of not being able to build with MSVC 2012 because it's three years old or so.  MSVC 2013 Update 4, on the other hand, is more like 3 months old.  Granted it's still readily available, but it hasn't made its way through the lab systems here yet and I suspect I'm not alone in experiencing this.

I'm not sure what the issue is.  This morning I could build just fine.  Now this afternoon, I can't because CMake thinks my compiler is too old.

What is the issue with ASTMatchers on earlier versions of MSVC?  Is it something that was just exposed by a recent commit?  I hadn't noticed a problem.

-Andy


-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Filipe Cabecinhas
Sent: Tuesday, February 17, 2015 3:29 PM
To: llvm-commits at cs.uiuc.edu
Subject: [llvm] r229584 - We require MSVC 2013 Update 4 due to previous versions miscompiling ASTMatchers

Author: filcab
Date: Tue Feb 17 17:29:00 2015
New Revision: 229584

URL: http://llvm.org/viewvc/llvm-project?rev=229584&view=rev
Log:
We require MSVC 2013 Update 4 due to previous versions miscompiling ASTMatchers

Previous versions of MSVC 2013 would miscompile ASTMatchers (and/or their tests). Bump up the requirement and make sure we know about the minor revision.

Minimum required version found by Michael Edwards!

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=229584&r1=229583&r2=229584&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Tue Feb 17 17:29:00 
+++ 2015
@@ -41,8 +41,8 @@ int main() { return (float)x; }"
       set(CMAKE_REQUIRED_LIBRARIES ${OLD_CMAKE_REQUIRED_LIBRARIES})
     endif()
   elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
-    if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 18.0)
-      message(FATAL_ERROR "Host Visual Studio must be at least 2013 (MSVC 18.0)")
+    if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 18.0.31101)
+      message(FATAL_ERROR "Host Visual Studio must be at least 2013 
+ Update 4 (MSVC 18.0.31101)")
     endif()
   endif()
 endif()


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits