[PATCH] Support for saving an ordered list of compilation units
Kostya Serebryany
kcc at google.com
Tue Feb 17 16:24:02 PST 2015
LGTM with two nits.
You don't have commit access, do you?
I'll commit this and http://reviews.llvm.org/D7702 once we are done.
================
Comment at: lib/sanitizer_common/sanitizer_coverage_libcdep.cc:85
@@ -84,3 +84,3 @@
void InitializeGuardArray(s32 *guards);
- void InitializeGuards(s32 *guards, uptr n);
+ void InitializeGuards(s32 *guards, uptr n, const char *mod_name);
void ReinitializeGuards();
----------------
module_name
================
Comment at: lib/sanitizer_common/sanitizer_coverage_libcdep.cc:113
@@ -112,1 +112,3 @@
+ // Vector of module (compilation unit) names
+ InternalMmapVectorNoCtor<const char*> comp_unit_name_vec;
----------------
period at the end.
http://reviews.llvm.org/D7703
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list