[llvm] r229352 - IR: Properly return nullptr when getAggregateElement is out-of-bounds

Hans Wennborg hans at chromium.org
Tue Feb 17 15:42:31 PST 2015


On Tue, Feb 17, 2015 at 3:17 PM, David Majnemer
<david.majnemer at gmail.com> wrote:
>
>
> On Tue, Feb 17, 2015 at 2:39 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Sun, Feb 15, 2015 at 8:02 PM, David Majnemer
>> <david.majnemer at gmail.com> wrote:
>> > Author: majnemer
>> > Date: Sun Feb 15 22:02:09 2015
>> > New Revision: 229352
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=229352&view=rev
>> > Log:
>> > IR: Properly return nullptr when getAggregateElement is out-of-bounds
>> >
>> > We didn't properly handle the out-of-bounds case for
>> > ConstantAggregateZero and UndefValue.  This would manifest as a crash
>> > when the constant folder was asked to fold a load of a constant global
>> > whose struct type has no operands.
>> >
>> > This fixes PR22595.
>>
>> Björn suggested we should merge this to 3.6. David, do you think this
>> would be ok?
>
>
> Yes, please merge this.

Merged in r229588.

Thanks,
Hans




More information about the llvm-commits mailing list