[PATCH] [ARM] Add missing M/R class CPUs

Bradley Smith bradley.smith at arm.com
Tue Feb 17 07:23:57 PST 2015


I've had a play with using defm etc for this, and whilst it does work it ends up being rather messy and unclear (especially when applied to all CPUs). I think in an ideal world the way I would structure this would be to model architectures rather than CPUs. That is, have subtarget features that represent architectures and enable the correct set of features for each, then have the CPUs inherit their architecture + extra bits rather than a full set of features. However as I mentioned, this cannot be done yet due to almost reaching the subtarget feature limit.

I think what I would propose is to commit this as is for now (perhaps with a TODO/FIXME), and once http://reviews.llvm.org/D7065 lands revisit this and restructure the whole thing to remove this kind of duplication and better represent the targets.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7668

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list