[PATCH] Generalize getExtendAddRecStart to work with both sign and zero extensions.

Andrew Trick atrick at apple.com
Tue Feb 17 00:42:25 PST 2015


Thanks for generalizing this. It would seem simpler to define an ExtendOpTraits base class parameterized on ExtendOp instead of triplicating the typedef. Otherwise LGTM.

I can't remember if there are other places we've tried to generalize SCEV extension ops. I don't see anything off hand.


http://reviews.llvm.org/D7645

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list