[PATCH] [Object] Support reading 64-bit MIPS ELF archives

Shankar Kalpathi Easwaran shankarke at gmail.com
Mon Feb 16 17:43:58 PST 2015


Can we also add a pointer to the specification in the code. It would be helpful for others if they happen to change this same code later.

Otherwise LGTM.


REPOSITORY
  rL LLVM

================
Comment at: include/llvm/Object/Archive.h:181
@@ -180,2 +180,3 @@
     K_GNU,
+    K_GNU64,
     K_BSD,
----------------
Should this be K_MIPS64 ?

http://reviews.llvm.org/D7546

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list