[PATCH] [LoopAccesses] Add -analyze support

hfinkel at anl.gov hfinkel at anl.gov
Mon Feb 16 17:28:27 PST 2015


LGTM.


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1287
@@ +1286,3 @@
+
+  if (Report) {
+    OS.indent(Depth) << "Report: " << Report->str() << "\n";
----------------
Don't need { } here.

================
Comment at: test/Analysis/LoopAccessAnalysis/unsafe-and-rt-checks.ll:2
@@ +1,3 @@
+; RUN: opt -loop-accesses -analyze < %s | FileCheck %s
+; RUN: opt -loop-accesses -analyze -debug-only=loop-accesses < %s 2>&1 | FileCheck %s --check-prefix=DEBUG
+
----------------
If you're checking debug output in a test, you need to add:

  ; REQUIRES: asserts

and please do that in a separate test so that we don't lose primary test coverage when compiling without Asserts enabled.

http://reviews.llvm.org/D7691

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list