[PATCH] [LoopAccesses] Make VectorizerParams global

hfinkel at anl.gov hfinkel at anl.gov
Mon Feb 16 16:09:21 PST 2015


Aside from the placement issue noted below, LGTM.


================
Comment at: include/llvm/Transforms/Utils/VectorUtils.h:205
@@ +204,3 @@
+/// Loop Access Analysis.
+struct VectorizerParams {
+  /// \brief Maximum SIMD width.
----------------
I'd prefer you leave this in include/llvm/Analysis/LoopAccessAnalysis.h, it does not really fit with the theme of this file (which is transformation-independent utilities dealing with vector intrinsics, etc.). Leaving it in LAA.h puts it near its user, which I like better.

http://reviews.llvm.org/D7680

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list