[PATCH] Add an experimental Sanitizer Windows builder

[Galina]

Thanks for working on this!

You may want to move slave_env_glob2list to the Util.py as well.

You do not check out any source code in getSanitizerWindowsBuildFactory. Is this intentional? If it is, could you remove all the unused imports, please?

Please also see my in-line comments.

Thanks

Galina


================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:17
@@ +16,3 @@
+            cmake='cmake',
+            jobs="%(jobs)s",
+
----------------
May I suggest using Property instead? Or at least reconcile this with property?
You are effectively loosing the "jobs" setting from your slaves.py.

Unless I'm missing something, we do not have a single use case yet when we really need to define jobs on the build factory level.

================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:40
@@ +39,3 @@
+
+    build_crt_cmd = ['ninja','compiler-rt']
+    build_cmd=['ninja']
----------------
Could you use NinjaCommand instead of using WarningCountingShellCommand with ninja directly, please? zorg/buildbot/commands/NinjaCommand.py should cover your needs.

================
Comment at: zorg/buildbot/builders/Util.py:3
@@ -3,1 +2,3 @@
 
+def generateVisualStudioEnvironment(vs=r"""%VS120COMNTOOLS%""", target_arch=None):
+    arch_arg = {'x86': 'x86', 'x64': 'amd64', 'amd64': 'amd64'}.get(target_arch, '%PROCESSOR_ARCHITECTURE%')
----------------
How about getVisualStudioEnvironment name or something similar?

http://reviews.llvm.org/D7675

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/