[PATCH] Revert 221429 and fix bug in TargetLowering::SimplifyDemandedBits

Quentin Colombet qcolombet at apple.com
Mon Feb 16 11:06:54 PST 2015


Hi Gil,

Thanks for your patience.

The patch does not impact the benchmarks in either direction.

LGTM, with a minor nitpick.

Thanks,
-Quentin


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:800
@@ +799,3 @@
+      unsigned VTBits = Op->getValueType(0).getScalarType().getSizeInBits();
+      bool alreadySignExtended =
+        TLO.DAG.ComputeNumSignBits(InOp) >= VTBits-ShAmt+1;
----------------
Variable names start with a capital letter.

http://reviews.llvm.org/D6949

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list