[PATCH] [LoopReroll] Run LICM before Loop Rerolling.

hfinkel at anl.gov hfinkel at anl.gov
Mon Feb 16 10:48:05 PST 2015


In http://reviews.llvm.org/D7674#124383, @jmolloy wrote:

> Hi Hal,
>
> OK, I managed to track it down (bugpoint didn't help, but I strained my eyes over every pass until I'd worked it out :) ).
>
> It comes from loop unrolling - we unroll part of a loop nest but don't run LICM afterwards to clean up. New patch adds it to the cleanup part of the scalar optimizer.


Okay, nice!

> As this was a latent bug, I don't think we need to smarten up the reroller to handle this - we should be able to expect our input to be optimized. Do you agree with this?


Yea, that's why I didn't handle them in the first place.

> Cheers,

> 

> James



REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7674

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list