[PATCH] Modularizing LICM

hfinkel at anl.gov hfinkel at anl.gov
Mon Feb 16 06:29:25 PST 2015


In http://reviews.llvm.org/D7291#124183, @ashutosh.nema wrote:

> Thanks Hal, Philip & Bruno for review.
>
> Incorporated review comments.
>
> Changes in this patch:
>
> 1. Introduced 'LICMSafetyInfo', earlier 'MayThrow' & 'HeaderMayThrow' was exposed outside. But now 'SinkRegion', 'HoistRegion' and 'PromoteAliasSet' will compute safety information.


But this means that each of these functions now needs to re-scan the loop to compute the safety information. I was hoping to avoid this extra expense. Please expose LICMSafetyInfo, and the utility function to compute it.


REPOSITORY
  rL LLVM

================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:76
@@ +75,3 @@
+/// DataLayout, TargetLibraryInfo, Loop and AliasSetTracker as argument
+/// and returns changed status. 
+bool SinkRegion(DomTreeNode *, AliasAnalysis *, LoopInfo *, DominatorTree *,
----------------
Please describe here, and in the function descriptions below, what is expected to be in the AliasSetTracker.

http://reviews.llvm.org/D7291

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list