[PATCH] Add invoke statepoint placement tests

Igor Laevsky igor at azulsystems.com
Mon Feb 16 03:22:52 PST 2015


Yes, Philip, please commit on my behalf.


REPOSITORY
  rL LLVM

================
Comment at: test/Transforms/PlaceSafepoints/invokes.ll:3
@@ +2,3 @@
+
+declare i64 addrspace(1)* @"some_call"(i64 addrspace(1)*)
+declare i32 @"personality_function"()
----------------
artagnon wrote:
> Why did you quote some_call? Doesn't it look ugly?
My code highlighting tool does a better job for quoted names. But I can remove quotes if you insist.

================
Comment at: test/Transforms/PlaceSafepoints/invokes.ll:10
@@ +9,3 @@
+  ; CHECK: invoke
+  ; CHECK: statepoint
+  %ret_val = invoke i64 addrspace(1)* @"some_call"(i64 addrspace(1)* %obj)
----------------
artagnon wrote:
> Do check for gc.statepoint.<sig>, because you don't know if you're matching a poll or a callsite in the original.
We will check for "invoke" followed by "statepoint". And we don't invoke polls as far as I know. So it must be original call site.

http://reviews.llvm.org/D7535

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list