[lld] r229072 - ELF/AArch64: Add support for checking for ABS32 overflow

[Will Newton]

On 14 February 2015 at 06:40, Michael Spencer <bigcheesegs at gmail.com> wrote:

Hi Michael,

> On Thu, Feb 12, 2015 at 10:22 PM, Will Newton <will.newton at linaro.org> wrote:
>> Author: wnewton
>> Date: Fri Feb 13 00:22:31 2015
>> New Revision: 229072
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=229072&view=rev
>> Log:
>> ELF/AArch64: Add support for checking for ABS32 overflow
>>
>> Add support for checking overflow when applying a R_AARCH64_ABS32
>> relocation and add a test to ensure it behaves correctly.
>
> This test fails for me on Windows.
>
> 66>  Command 2: "FileCheck"
> "C:\Users\mspencer\Projects\llvm-project\lold\test\elf\AArch64\rel-abs32-overflow.test"
> 66>  Command 2 Result: 1
> 66>  Command 2 Output:
> 66>
> 66>
> 66>  Command 2 Stderr:
> 66>  C:\Users\mspencer\Projects\llvm-project\lold\test\elf\AArch64\rel-abs32-overflow.test:6:10:
> error: expected string not found in input
> 66>
> 66>  # CHECK: Relocation out of range in file {{.*}}: reference from
> data2+0 to data1+34359738369 of type 258 (R_AARCH64_ABS32)
> 66>
> 66>           ^
> 66>
> 66>  <stdin>:3:1: note: scanning from here
> 66>
> 66>CUSTOMBUILD : LLVM error : relocating output
> 66>
> 66>  ^

Sorry for the delay in looking at this, I've been travelling and only
just got caught up.

I guess this is due to the filename regex failing to work correctly
for Windows paths - is there an idiomatic way to fix that?

Would something like:

CHECK: Relocation out of range in file {{.*}}rel-abs32-overflow{{.*}}:
reference from data1+0 to data2+34359738369 of type 258
(R_AARCH64_ABS32)

Work for you? I don't have any Windows machines to test on.

-- 
Will Newton
Toolchain Working Group, Linaro