[PATCH] A bit-tracking DCE Pass

James Molloy james at jamesmolloy.co.uk
Mon Feb 16 00:59:09 PST 2015


Hi Hal,

I'm fine with it landing in-tree and then doing the refactoring from there.
I can even do it if needed :)

A utility class seems about right - the only thing I'm trying to avoid is
duplication of the algorithm.

Cheers,

James

On Mon Feb 16 2015 at 2:45:11 AM hfinkel at anl.gov <hfinkel at anl.gov> wrote:

> In http://reviews.llvm.org/D7531#123925, @hfinkel wrote:
>
> > In http://reviews.llvm.org/D7531#123922, @jmolloy wrote:
> >
> > > Hi Hal,
> > >
> > > I'm looking at using very similar information in a pass I'm writing
> (live bits information). Would it be easy enough to move the AliveBits
> stuff into a utility class so it can be called from elsewhere?
> >
> >
> > Yes, I think we could separate the analysis part from the part that
> removes the completely-dead parts. If you can tell me, what are you working
> on?
>
>
> Upon further reflection, I'm not sure what the right refactoring for this
> would be. It could be an analysis pass, but it could also be a utility
> class exported from here. An actual analysis pass may not be particularly
> useful here because I don't think it would be likely to be preserved by any
> non-trivial transformation. I don't think there is any real way to "locally
> repair" the analysis after making a change (you could update it to get
> conservative answer, but because you never remove live bits under
> iteration, you'd not get the same answer as you might running the analysis
> from the beginning).
>
> As a result, we might want to get this functionality in-tree, and then
> refactor it there.
>
> >
>
> >
>
> > > Cheers,
>
> >
>
> > >
>
> >
>
> > > James
>
> >
>
>
>
> http://reviews.llvm.org/D7531
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150216/21d52607/attachment.html>


More information about the llvm-commits mailing list