[PATCH] Refine getLLDBUbuntuCMakeBuildFactory function based on code review feedback
Siva Chandra
sivachandra at google.com
Sun Feb 15 00:50:00 PST 2015
LGTM with just one nit.
I am assuming you have tested this.
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:282
@@ +281,3 @@
+ "-GNinja",
+ ]
+ if build_compiler == "clang":
----------------
nit: This list can just be on one line.
http://reviews.llvm.org/D7599
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list