[PATCH] fix test-suite/SingleSource/UnitTests/ObjC for iOS SDK

Daniel Dunbar daniel at zuster.org
Sat Feb 14 10:12:59 PST 2015


LGTM

On Friday, February 13, 2015, Matthias Braun <mbraun at apple.com> wrote:

> ping
>
> On Jan 26, 2015, at 10:25 AM, Matthias Braun <mbraun at apple.com
> <javascript:_e(%7B%7D,'cvml','mbraun at apple.com');>> wrote:
>
> Thanks for the review. I updated the messages-2 patch as suggested.
>
> - Matthias
>
> <0001-Avoid-using-NSSize-which-is-not-available-on-iOS.patch>
>
> On Jan 23, 2015, at 4:16 PM, Daniel Dunbar <daniel at zuster.org
> <javascript:_e(%7B%7D,'cvml','daniel at zuster.org');>> wrote:
>
> The patch to messages-2.m should probably just substitute an inline
> definition of a size class, IIRC (and its been a long time) the test is
> trying to explicitly check a particular structure layout, so it would be
> better to just hardcode the definition as:
> --
> typedef struct {
>   float width, height;
> } MySize;
> --
> since this test was originally intended for testing the 32-bit structure
> layout, I think.
>
>  - Daniel
>
>
> On Fri, Jan 23, 2015 at 2:55 PM, Matthias Braun <mbraun at apple.com
> <javascript:_e(%7B%7D,'cvml','mbraun at apple.com');>> wrote:
>
>> The attached patches fix two problems when running
>> test-suite/SingleSource/UnitTests/ObjC with the iOS SDK.
>>
>> - Matthias
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> <javascript:_e(%7B%7D,'cvml','llvm-commits at cs.uiuc.edu');>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150214/4994f720/attachment.html>


More information about the llvm-commits mailing list