[compiler-rt] r229116 - tsan: disable deadlock detector in Go mode

[Dmitry Vyukov]

On Sat, Feb 14, 2015 at 1:41 AM, Alexey Samsonov <vonosmas at gmail.com> wrote:
>
> On Fri, Feb 13, 2015 at 7:44 AM, Dmitry Vyukov <dvyukov at google.com> wrote:
>>
>> Author: dvyukov
>> Date: Fri Feb 13 09:44:50 2015
>> New Revision: 229116
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=229116&view=rev
>> Log:
>> tsan: disable deadlock detector in Go mode
>>
>> Go does not use that.
>> https://code.google.com/p/thread-sanitizer/issues/detail?id=89
>>
>>
>> Modified:
>>     compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc
>>
>> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc?rev=229116&r1=229115&r2=229116&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc (original)
>> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc Fri Feb 13 09:44:50 2015
>> @@ -62,7 +62,9 @@ void InitializeFlags(Flags *f, const cha
>>      CommonFlags cf;
>>      cf.CopyFrom(*common_flags());
>>      cf.allow_addr2line = true;
>> +#ifndef SANITIZER_GO
>>      cf.detect_deadlocks = true;
>> +#endif
>
>
> Can this be
>   cf.detect_deadlocks = !SANITIZER_GO
> ?

Yes, if all non-Go builds of tsan define SANITIZER_GO to 0.