[PATCH] [CodeGenPrepare] Removed duplicated logic. SimplifyCFG now knows how to speculate calls to cttz/ctlz.

Andrea Di Biagio Andrea_DiBiagio at sn.scee.net
Fri Feb 13 03:42:48 PST 2015


Hi hfinkel, arsenm,

Since revisions 228829 (code review: D7554) and 228923 (code review: D7554), SimplifyCFG knows how to speculate calls to intrinsic cttz/ctlz that are 'cheap' for the target. The logic in CodeGenPrepare (originally added at revision 224899) is now redundant and can therefore be removed.

This patch removes the duplicated logic in CodeGenPrepare and converts all the existing target specific tests for cttz/ctlz into SimplifyCFG tests. Note that X86 tests were already added by revisions 228829 and 228923. No functional change intended.

Please let me know if ok to submit.

Thanks,
Andrea

http://reviews.llvm.org/D7608

Files:
  lib/CodeGen/CodeGenPrepare.cpp
  test/CodeGen/PowerPC/cttz-ctlz-spec.ll
  test/CodeGen/R600/cttz-ctlz.ll
  test/CodeGen/X86/cttz-ctlz.ll
  test/Transforms/SimplifyCFG/PowerPC/cttz-ctlz-spec.ll
  test/Transforms/SimplifyCFG/PowerPC/lit.local.cfg
  test/Transforms/SimplifyCFG/R600/cttz-ctlz.ll
  test/Transforms/SimplifyCFG/R600/lit.local.cfg

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7608.19878.patch
Type: text/x-patch
Size: 41305 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150213/b48c7288/attachment.bin>


More information about the llvm-commits mailing list