[PATCH] A bit-tracking DCE Pass

hfinkel at anl.gov hfinkel at anl.gov
Thu Feb 12 22:09:09 PST 2015


================
Comment at: lib/Transforms/Scalar/BDCE.cpp:144
@@ +143,3 @@
+         OI != OE; ++OI)
+      if (Instruction* I = dyn_cast<Instruction>(OI)) {
+        if (IntegerType *IT = dyn_cast<IntegerType>(I->getType())) {
----------------
majnemer wrote:
> hfinkel wrote:
> > majnemer wrote:
> > > Pointer on the right hand side.
> > I don't understand. The RHS has OI, which is an Instruction::op_iterator, which is a Use*.
> I was referring to your `Instruction* I`, I think it should be `Instruction *I`.
Agreed. (I think this was one of the copy-and-paste lines from ADCE; I'll need to remember to clean this up in both places).

http://reviews.llvm.org/D7531

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list