[PATCH] CodeGenPrepare: Avoid and/or i1 in select conditions.
hfinkel at anl.gov
hfinkel at anl.gov
Thu Feb 12 21:53:41 PST 2015
REPOSITORY
rL LLVM
================
Comment at: llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp:1195
@@ +1194,3 @@
+ SI.setOperand(1, TrueSI->getTrueValue());
+ return &SI;
+ }
----------------
I think that you want to explicitly add And to the worklist here (assuming that the builder has not constant-folded it).
if (Instruction *AndI = dyn_cast<Instruction>(And))
Worklist.Add(AndI);
otherwise we might not actually revisit it until the next main outer instcombine iteration.
http://reviews.llvm.org/D7399
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list