[llvm] r229063 - [InstCombine] Fix a bug when combining `icmp` from `ptrtoint`

Chandler Carruth chandlerc at google.com
Thu Feb 12 21:34:23 PST 2015


On Thu, Feb 12, 2015 at 8:51 PM, Michael Liao <michael.liao at intel.com>
wrote:

> Author: hliao
> Date: Thu Feb 12 22:51:26 2015
> New Revision: 229063
>
> URL: http://llvm.org/viewvc/llvm-project?rev=229063&view=rev
> Log:
> [InstCombine] Fix a bug when combining `icmp` from `ptrtoint`
>
> - First, there's a crash when we try to combine that pointers into `icmp`
>   directly by creating a `bitcast`, which is invalid if that two pointers
> are
>   from different address spaces.
>
> - It's not always appropriate to cast one pointer to another if they are
> from
>   different address spaces as that is not no-op cast. Instead, we only
> combine
>   `icmp` from `ptrtoint` if that two pointers are of the same address
> space.
>

Are these regressions from 3.5?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150212/3e451806/attachment.html>


More information about the llvm-commits mailing list