[llvm] r229053 - [unroll] Extract the code to enqueue operansd for the worklist in the
Chandler Carruth
chandlerc at gmail.com
Thu Feb 12 19:49:41 PST 2015
Author: chandlerc
Date: Thu Feb 12 21:49:41 2015
New Revision: 229053
URL: http://llvm.org/viewvc/llvm-project?rev=229053&view=rev
Log:
[unroll] Extract the code to enqueue operansd for the worklist in the
unroll analysis into a lambda and call it. That's much simpler than
duplicating all the code.
Modified:
llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
Modified: llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp?rev=229053&r1=229052&r2=229053&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp Thu Feb 12 21:49:41 2015
@@ -509,6 +509,15 @@ public:
// worklist.
SmallPtrSet<Instruction *, 4> OperandSet;
+ // Lambda to enque operands onto the worklist.
+ auto EnqueueOperands = [&](Instruction &I) {
+ OperandSet.clear();
+ for (auto *Op : I.operand_values())
+ if (auto *OpI = dyn_cast<Instruction>(Op))
+ if (OperandSet.insert(OpI).second)
+ Worklist.push_back(OpI);
+ };
+
// Start by initializing worklist with simplified instructions.
for (auto &FoldedKeyValue : SimplifiedValues)
if (auto *FoldedInst = dyn_cast<Instruction>(FoldedKeyValue.first)) {
@@ -516,11 +525,7 @@ public:
// Add each instruction operand of this dead instruction to the
// worklist.
- OperandSet.clear();
- for (auto *Op : FoldedInst->operand_values())
- if (auto *OpI = dyn_cast<Instruction>(Op))
- if (OperandSet.insert(OpI).second)
- Worklist.push_back(OpI);
+ EnqueueOperands(*FoldedInst);
}
// If a definition of an insn is only used by simplified or dead
@@ -545,11 +550,7 @@ public:
if (AllUsersFolded) {
NumberOfOptimizedInstructions += TTI.getUserCost(I);
DeadInstructions.insert(I);
- OperandSet.clear();
- for (auto *Op : I->operand_values())
- if (auto *OpI = dyn_cast<Instruction>(Op))
- if (OperandSet.insert(OpI).second)
- Worklist.push_back(OpI);
+ EnqueueOperands(*I);
}
}
return NumberOfOptimizedInstructions;
More information about the llvm-commits
mailing list