[PATCH] DAGCombiner: Continue combining if FoldConstantArithmetic() fails.

Ahmed Bougacha ahmed.bougacha at gmail.com
Thu Feb 12 11:09:12 PST 2015


Peppering "isOpaque" checks in the remaining combines seems awfully brittle.

Basically, folding to constants isn't OK, but folding to undef is, correct?  How about flipping the check then:  do all the combines that are valid on Opaque constants first (-> undef), and then bail out if the constant is Opaque but we couldn't do anything.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D6946

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list