[PATCH] [TSan][MIPS64] Fix go build for MIPS64

Alexey Samsonov vonosmas at gmail.com
Thu Feb 12 10:11:44 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/tsan/CMakeLists.txt:105
@@ -104,2 +104,3 @@
 set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/go/buildgo.sh)
+set(arch ${TSAN_SUPPORTED_ARCH})
 add_custom_target(GotsanRuntimeCheck
----------------
You need to have GotsanRuntimeCheck for every ${arch} from ${TSAN_SUPPORTED_ARCH}.

================
Comment at: lib/tsan/go/buildgo.sh:87
@@ -86,1 +86,3 @@
 	"
+elif [ "`uname -a | grep mips64 | grep Linux`" != "" ]; then
+        SUFFIX="linux_mips64"
----------------
This part is far too similar to linux_amd64. I believe you should generalize the former.

================
Comment at: lib/tsan/go/buildgo.sh:131
@@ -115,1 +130,3 @@
 	FLAGS="$FLAGS -DSANITIZER_DEBUG=0 -O3 -msse3 -fomit-frame-pointer"
+elif [ "$DEBUG" = "" -a "`uname -a | grep mips64`" != "" ]; then
+	FLAGS="$FLAGS -DSANITIZER_DEBUG=0 -O3 -fomit-frame-pointer"
----------------
ditto

http://reviews.llvm.org/D7582

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list