[PATCH] Beginning of alloca implementation for Mips fast-isel

Daniel Sanders daniel.sanders at imgtec.com
Thu Feb 12 08:42:47 PST 2015


================
Comment at: lib/Target/Mips/MipsFastISel.cpp:380-381
@@ +379,4 @@
+           }
+           // Unsupported
+           goto unsupported_gep;
+         }
----------------
dsanders wrote:
> I see that the AArch64 port did this too but why use goto when the target of the goto simply does 'break'?
To answer my own question after re-reading the code: Because we're trying to break out of two for-loops and the break at the target is for the switch-statement.

http://reviews.llvm.org/D6426

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list