[PATCH] [LoopRerolling] Be more forgiving with instruction order.

hfinkel at anl.gov hfinkel at anl.gov
Thu Feb 12 05:29:40 PST 2015


LGTM.


REPOSITORY
  rL LLVM

================
Comment at: lib/Transforms/Scalar/LoopRerollPass.cpp:52
@@ +51,3 @@
+                          cl::desc("The maximum number of failures to tolerate"
+                                   " during fuzzy matching. (default: 4)"));
+
----------------
Please make this default 400, not 4. A search threshold like 4 is likely to cause cases where seemingly innocuous source changes drastically change code performance. We just want to limit the worst case.

http://reviews.llvm.org/D7562

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list