[llvm] r223113 - Add support for ARM modified-immediate assembly syntax.

Eric Christopher echristo at gmail.com
Wed Feb 11 15:01:39 PST 2015


Hi Steven,

Is it a legal instruction? :)

If so, it's been a week, I think we should just revert back to green and
add a test that the instruction is assembled properly.

-eric

On Wed Feb 11 2015 at 2:58:52 PM Steven Wu <stevenwu at apple.com> wrote:

> Hi Asiri
>
> Have you had a chance to look at this problem yet? Since the immediates
> are evaluated as int64_t, I cannot see an easy way to fix this. I don’t
> think we can allow a false positive for this error message either. Do you
> have any solution?
>
> Thanks
>
> Steven
>
> On Feb 4, 2015, at 12:10 PM, Steven Wu <stevenwu at apple.com> wrote:
>
> Hi Asiri
>
> I see this instruction, which I believe is legal, gets an error now:
> mvn sp, #(~(0xffffff00))
> Can you look at this as well? Thanks!
>
> Steven
>
>
> On Dec 4, 2014, at 7:27 AM, Asiri Rathnayake <asiri.rathnayake at gmail.com>
> wrote:
>
> Should be fixed in r223366
>
> Best,
>
> - Asiri
>
> On Wed, Dec 3, 2014 at 6:39 PM, Joerg Sonnenberger <
> joerg at britannica.bec.de> wrote:
>
>> On Tue, Dec 02, 2014 at 10:53:21AM -0000, Asiri Rathnayake wrote:
>> > Author: asiri
>> > Date: Tue Dec  2 04:53:20 2014
>> > New Revision: 223113
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=223113&view=rev
>> > Log:
>> > Add support for ARM modified-immediate assembly syntax.
>>
>> I see failures like
>>
>>         adds r3, r0, #(32 * 4)
>>
>> being rejected now. Can you check if that is your commit?
>>
>> Joerg
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150211/2e384f24/attachment.html>


More information about the llvm-commits mailing list