[PATCH] [LoopVectorize] Move LoopAccessAnalysis to its own module

[Hal Finkel]

----- Original Message -----
> From: "Adam Nemet" <anemet at apple.com>
> To: reviews+D7285+public+8a97e71255c10d4e at reviews.llvm.org
> Cc: "Arnold Schwaighofer" <aschwaighofer at apple.com>, "Hal Finkel" <hfinkel at anl.gov>, "llvm-commits"
> <llvm-commits at cs.uiuc.edu>, "Nadav Rotem <nrotem at apple.com> (nrotem at apple.com)" <nrotem at apple.com>
> Sent: Wednesday, February 11, 2015 4:06:56 PM
> Subject: Re: [PATCH] [LoopVectorize] Move LoopAccessAnalysis to its own module
> 
> 
> > On Jan 31, 2015, at 7:17 PM, Adam Nemet <anemet at apple.com> wrote:
> > 
> > In http://reviews.llvm.org/D7285#116434, @hfinkel wrote:
> > 
> >> I'm assuming the idea is to turn this into a proper analysis pass,
> >> but this is a good intermediate step. LGTM.
> > 
> > 
> > Yes, this was the first step of pure refactoring.  Thanks.
> 
> I am at a point where turning this into an analysis pass seems to be
> working.  Still missing some testing, etc.
> 
> It’s a function pass that provides an interface to query the memory
> access information for a given loop.  The result of the analysis is
> computed on-demand when the client queries it and then cached in the
> analysis pass.
> 
> Does this approach sound reasonable?

Makes sense to me. We have a number of analysis that do on-demand computation (ScalarEvolution and LazyValueInfo, for example).

 -Hal

> 
> Adam
> 
> > 
> > 
> > http://reviews.llvm.org/D7285
> > 
> > EMAIL PREFERENCES
> >  http://reviews.llvm.org/settings/panel/emailpreferences/
> > 
> > 
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory