[compiler-rt] r228384 - [UBSan] Enable -Wglobal-constructors.

[Yury Gribov]

On 02/11/2015 09:04 AM, Yury Gribov wrote:
> On 02/11/2015 06:07 AM, Justin Bogner wrote:
>> Alexey Samsonov <vonosmas at gmail.com> writes:
>>> Ah, right...
>>> Feel free to revert this change. I have plans to deal with different
>>> UBSan
>>> initialization issues soon, and will see if I would be able to
>>> reinstantiate
>>> this warning on all platforms.
>>
>> Reverted in r228795.
>
> Can't we just move initializer to separate file for which we then
> disable this warning?

Does something like this make sense? It passes tests on Linux x64. I 
haven't verified OSX but I can see that -Wglobal-constructors is indeed 
disabled for ubsan_init.cc.

-Y

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ubsan-global-ctors-2.diff
Type: text/x-patch
Size: 788 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150211/8ddf2422/attachment.bin>