[PATCH] Merge lldb-platform and lldb-gdbserver into a single binary.
Vince Harron
vharron at google.com
Tue Feb 10 21:40:25 PST 2015
REPOSITORY
rL LLVM
================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp:493
@@ -492,3 +492,3 @@
// FIXME This looks an awful lot like we could override this in
- // derived classes, one for lldb-platform, the other for lldb-gdbserver.
+ // derived classes, one for platform, the other for gdbserver.
if (IsGdbServer ())
----------------
I actually don't like lldb being removed from lldb-gdbserver. Then you just have something that doesn't make sense, because it isn't gdbserver. I think we should stick with lldb-gdbserver and also lldb-platform to differentiate the platform process from the platform command/concept.
http://reviews.llvm.org/D7545
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list