[PATCH] [UBSan] Allow UBSan location to store frames returned by symbolizer.

Alexey Samsonov vonosmas at gmail.com
Tue Feb 10 19:18:24 PST 2015


================
Comment at: lib/ubsan/ubsan_diag.h:29
@@ -27,1 +28,3 @@
+      Stack->ClearAll();
+  }
 
----------------
filcab wrote:
> Aren't we still leaking the SymbolizedStack object, here? (as well as in the destructor and reset() (which call clear()))
> I guess we're missing a call to InternalFree()
SymbolizedStack::ClearAll() calls InternalFree(this), so it shouldn't be necessary.

http://reviews.llvm.org/D7548

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list