[compiler-rt] r228795 - Revert "[UBSan] Enable -Wglobal-constructors."

Justin Bogner mail at justinbogner.com
Tue Feb 10 19:05:03 PST 2015


Author: bogner
Date: Tue Feb 10 21:05:02 2015
New Revision: 228795

URL: http://llvm.org/viewvc/llvm-project?rev=228795&view=rev
Log:
Revert "[UBSan] Enable -Wglobal-constructors."

We're still using global constructors when not on linux, so this was
causing warnings on Darwin. Reverting for now.

This reverts r228384.

Modified:
    compiler-rt/trunk/lib/ubsan/CMakeLists.txt

Modified: compiler-rt/trunk/lib/ubsan/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/ubsan/CMakeLists.txt?rev=228795&r1=228794&r2=228795&view=diff
==============================================================================
--- compiler-rt/trunk/lib/ubsan/CMakeLists.txt (original)
+++ compiler-rt/trunk/lib/ubsan/CMakeLists.txt Tue Feb 10 21:05:02 2015
@@ -17,12 +17,7 @@ include_directories(..)
 
 set(UBSAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})
 append_no_rtti_flag(UBSAN_CFLAGS)
-append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors
-               UBSAN_CFLAGS)
-
 set(UBSAN_CXXFLAGS ${SANITIZER_COMMON_CFLAGS})
-append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors
-               UBSAN_CXXFLAGS)
 
 add_custom_target(ubsan)
 





More information about the llvm-commits mailing list