[PATCH] Add LLDB x86_64 Ubuntu 14.04 builder
Siva Chandra
sivachandra at google.com
Tue Feb 10 11:48:12 PST 2015
================
Comment at: buildbot/osuosl/master/config/builders.py:684
@@ +683,3 @@
+ 'builddir': "buildWorkingDir",
+ 'factory': LLDBBuilder.getLLDBUbuntuCMakeBuildFactory(
+ triple=None,
----------------
chying wrote:
> sivachandra wrote:
> > I could have missed, but don't remember seeing a patch which added getLLDBUbuntuCMakeBuildFactory. Is there one on phabricator?
> Thank you Siva.
> Yes, there's another patch adding getLLDBUbuntuCMakeBuildFactory.
> Somehow it did not generate email to reviewers.
> Here is the link,
> http://reviews.llvm.org/D7521
>
Thanks.
Should the builder name reflect that this uses cmake? For example, lldb-x86_64-ubuntu-14.04-cmake? [That it uses ninja is probably not that very important that it should be captured in the builder name.]
================
Comment at: buildbot/osuosl/master/config/slaves.py:189
@@ +188,3 @@
+
+ # Ubuntu x86-64, 51GiB System memory Intel(R) Xeon(R) CPU @ 2.60GHz
+ create_slave("lldb-build1-ubuntu-1404", properties={'jobs': 16, 'loadaverage':
----------------
chying wrote:
> sivachandra wrote:
> > Is this accurate?
> The information was from running $lshw on builder.
>
Is this guaranteed? That is, does GCE guarantee that this will not change? Why is it important to have a comment describing the hardware?
http://reviews.llvm.org/D7523
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list