[llvm] r228596 - MemDepPrinter: cleanup a few loops (NFC)

[Duncan P. N. Exon Smith]

> On 2015-Feb-09, at 11:49, Ramkumar Ramachandra <artagnon at gmail.com> wrote:
> 
> Author: artagnon
> Date: Mon Feb  9 13:49:54 2015
> New Revision: 228596
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=228596&view=rev
> Log:
> MemDepPrinter: cleanup a few loops (NFC)
> 
> Make use of the newly introduced inst_range to clean up two loops. Clean
> up a third one while at it.
> 
> Differential Revision: http://reviews.llvm.org/D7455
> 
> Modified:
>    llvm/trunk/lib/Analysis/MemDepPrinter.cpp
> 
> Modified: llvm/trunk/lib/Analysis/MemDepPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/MemDepPrinter.cpp?rev=228596&r1=228595&r2=228596&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Analysis/MemDepPrinter.cpp (original)
> +++ llvm/trunk/lib/Analysis/MemDepPrinter.cpp Mon Feb  9 13:49:54 2015
> @@ -96,8 +96,8 @@ bool MemDepPrinter::runOnFunction(Functi
> 
>   // All this code uses non-const interfaces because MemDep is not
>   // const-friendly, though nothing is actually modified.
> -  for (inst_iterator I = inst_begin(F), E = inst_end(F); I != E; ++I) {
> -    Instruction *Inst = &*I;
> +  for (auto &I: inst_range(F)) {

There should be a ` ` (space) before the `:` (colon).  Clang-format
next time?

> +    Instruction *Inst = &I;
> 
>     if (!Inst->mayReadFromMemory() && !Inst->mayWriteToMemory())
>       continue;
> @@ -135,8 +135,8 @@ bool MemDepPrinter::runOnFunction(Functi
> }
> 
> void MemDepPrinter::print(raw_ostream &OS, const Module *M) const {
> -  for (const_inst_iterator I = inst_begin(*F), E = inst_end(*F); I != E; ++I) {
> -    const Instruction *Inst = &*I;
> +  for (auto &I: inst_range(*F)) {

Same here.  Also, use `const auto &I` to make clear that you're not
modifying `I`.

> +    const Instruction *Inst = &I;
> 
>     DepSetMap::const_iterator DI = Deps.find(Inst);
>     if (DI == Deps.end())
> @@ -144,11 +144,10 @@ void MemDepPrinter::print(raw_ostream &O
> 
>     const DepSet &InstDeps = DI->second;
> 
> -    for (DepSet::const_iterator I = InstDeps.begin(), E = InstDeps.end();
> -         I != E; ++I) {
> -      const Instruction *DepInst = I->first.getPointer();
> -      DepType type = I->first.getInt();
> -      const BasicBlock *DepBB = I->second;
> +    for (auto &I: InstDeps) {

Same here.  Also, use `const auto &I`.

> +      const Instruction *DepInst = I.first.getPointer();
> +      DepType type = I.first.getInt();
> +      const BasicBlock *DepBB = I.second;
> 
>       OS << "    ";
>       OS << DepTypeStr[type];
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits