[PATCH] [mips] Merge disassemblers into a single implementation.

Vladimir Medic Vladimir.Medic at imgtec.com
Tue Feb 10 05:24:58 PST 2015


================
Comment at: test/MC/Disassembler/Mips/mips32r2/valid-mips32r2-le.txt:2
@@ -2,2 +1,3 @@
+# RUN: llvm-mc --disassemble %s -triple=mips64el-unknown-linux -mcpu=mips32r2 | FileCheck %s
 0x05 0x73 0x20 0x46 # CHECK: abs.d $f12, $f14
 0x85 0x39 0x00 0x46 # CHECK: abs.s $f6, $f7
----------------
Why using mips64 triple here?

================
Comment at: test/MC/Disassembler/Mips/mips32r2/valid-mips32r2.txt:2
@@ -2,2 +1,3 @@
+# RUN: llvm-mc --disassemble %s -triple=mips64-unknown-linux -mcpu=mips32r2 | FileCheck %s
 0x46 0x20 0x73 0x05 # CHECK: abs.d $f12, $f14
 0x46 0x00 0x39 0x85 # CHECK: abs.s $f6, $f7
----------------
Same as above.

================
Comment at: test/MC/Disassembler/Mips/mips64r2/valid-mips64r2-el.txt:2
@@ -2,2 +1,3 @@
+# RUN: llvm-mc --disassemble %s -triple=mipsel-unknown-linux -mcpu=mips64r2 | FileCheck %s
 # CHECK: .text
 0x05 0x73 0x20 0x46 # CHECK: abs.d $f12, $f14
----------------
shouldn't it be mips64 triple here?

================
Comment at: test/MC/Disassembler/Mips/mips64r2/valid-mips64r2.txt:2
@@ -2,2 +1,3 @@
+# RUN: llvm-mc --disassemble %s -triple=mips-unknown-linux -mcpu=mips64r2 | FileCheck %s
 # CHECK: .text
 0x46 0x20 0x73 0x05 # CHECK: abs.d $f12, $f14
----------------
Also here.

http://reviews.llvm.org/D7498

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list