[PATCH] Fix llvm::sys::path::home_directory on unix to get path from passwd.pw_dir when the $HOME variable isn't set

[Ilia K]

Hello Chandler,

> RE: But what platform is it that we're hypothetically supporting? All the BSD and Linux flavors I know of rely heavily on the HOME environment variable. All the build bots I know of test under that assumption. I'm worried about adding code to support another variant that we have essentially no way of testing and no knowledge of why it was important.


I'm working on OS X but in this case I launch lldb from another process. Perhaps I forgot to pass HOME variable in execve(). I didn't know that lldb (and llvm) uses that variable. I think we should fix it to avoid such problems in the future (or warn that HOME variable isn't set).

Thanks,
Ilia


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7515

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/