[PATCH] Teach llvm_add_library() to search arbitrary directories for includes.
Zachary Turner
zturner at google.com
Mon Feb 9 18:24:45 PST 2015
Yes, will probably do that as a followup, and simultaneously deprecate the
use of ADDITIONAL_HEADERS.
If someone really wanted to get clever, they could also update
llvm_add_library to translate the source directory to a corresponding
include directory and automatically append it to ADDITIONAL_HEADER_DIRS.
This would make all IDE projects way better in my opinion.
On Mon, Feb 9, 2015 at 4:37 PM Chris Bieneman <beanz at apple.com> wrote:
> LGTM. This seems like general goodness that reduces the complexity of our
> CMake files, and I verified it works as expected for Xcode.
>
> Can you please cleanup any uses of ADDITIONAL_HEADERS that make sense?
>
>
> http://reviews.llvm.org/D7460
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150210/9eda35cd/attachment.html>
More information about the llvm-commits
mailing list