[PATCH] [lld][ELF][ARM] Add veneer generation to branch instructions
Will Newton
will.newton at linaro.org
Mon Feb 9 17:44:11 PST 2015
================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp:157
@@ +156,3 @@
+ const auto kindValue = ref.kindValue();
+ if (R_ARM_CALL == kindValue || R_ARM_THM_CALL == kindValue)
+ // TODO: need additional check of arch type as it should be
----------------
It seems like it might be simpler not to pass R_*_CALL relocations into this function at all then we could remove the handling here and in the switch statement below (but retain a comment about ARMv5).
http://reviews.llvm.org/D7502
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list