[PATCH] Driver: Replace switch cases with ifs.

[Rui Ueyama]

This is one of series of patches, and I'll do this for other drivers as
well.

On Mon, Feb 9, 2015 at 3:53 PM, Shankar Easwaran <shankare at codeaurora.org>
wrote:

>  I already LGTM the patch for PECOFF.
>
>
> On 2/9/2015 5:41 PM, Rui Ueyama wrote:
>
> That's what I wanted to ask you. We didn't have this gigantic switch and
> lots of break's there but a series of small ifs. You did converted them as
> a part of unrelated change (which is the large InputGraph patch) without
> any explanation. Yes, the original code looks better to me, and I guess
> that's at least part of the reason why the original code was written as it
> was. I'm basically trying to restore the original code.
>
> On Fri, Feb 6, 2015 at 7:40 PM, Shankar Kalpathi Easwaran <shankarke at gmail.com> wrote:
>
>
>  I really dont understand, Its a matter of style, every developer may
> choose to follow different styles. Nothing is written in the coding
> convention document about what style to choose over another.
>
> http://reviews.llvm.org/D7478
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
>
> _______________________________________________
> llvm-commits mailing listllvm-commits at cs.uiuc.eduhttp://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150209/b653c548/attachment.html>