[PATCH] PlaceSafepoints: use IRBuilder helpers

Philip Reames listmail at philipreames.com
Mon Feb 9 14:54:27 PST 2015


The relocate part of this change LGTM w/one change:  The old code took the name of the replaced call for the result.  This is useful for keeping the IR readable.  Please add a test for this as well.

The statepoint parts I would prefer to delay a week or so.  I'm waiting on a coworker to land the invoke specific tests and I want that to happen before adjusting the codepath in question.


http://reviews.llvm.org/D7518

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list