[PATCH] IR: Take uint64_t in DIBuilder::createExpression()

Duncan P. N. Exon Smith dexonsmith at apple.com
Mon Feb 9 14:15:38 PST 2015


r228619

> On 2015-Feb-09, at 13:34, Adrian Prantl <aprantl at apple.com> wrote:
> 
> LGTM.
> -- adrian
>> On Feb 9, 2015, at 1:23 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> 
>> `DIExpression` deals with `uint64_t`, so it doesn't make sense that
>> `createExpression()` is created from `int64_t`.  Switch to `uint64_t` to
>> unify them.
>> 
>> I've temporarily left in the `int64_t` version, which forwards to the
>> `uint64_t` version.  I'll delete it once I've updated the callers.
>> 
>> Just before I go down this road, can you confirm it's the correct
>> direction?  Or should `DIExpression` be changed to use `int64_t`?
>> 
>> <0001-IR-Take-uint64_t-in-DIBuilder-createExpression.patch>
> 





More information about the llvm-commits mailing list