[PATCH] SelectionDAG: fold (fp_to_u/sint (u/sint_to_fp val)) when possible

[Sanjay Patel]

For the test case:
1. This isn't x86 specific: remove -mcpu
2. Minimize the test cases:
  a. Remove alloca, store, load
  b. Remove function attributes
3. Improve the CHECKs: test for the exact expected output; there shouldn't
be any variation in the output with this transform.
4. You should just be able to add these test cases to the existing
sitofp.ll test file? If you do that, please fix that file to use FileCheck,
CHECK-LABEL, etc. Preferably, that would be a separate patch before yours.


On Mon, Feb 9, 2015 at 2:44 PM, Fiona Glaser <fglaser at apple.com> wrote:

>
> Target-specific expansion or combine can end-up with this situation when
> it was not catched by ints-combine.
>
> So I believe we want it to be done *both* in inst-combine *and* in the DAG.
>
>
> I agree. That is also what I meant in my initial message.
>
> Cheers,
> Q.
>
>
> Okay, should I merge the two patches then (and maybe include both tests)?
>
> Fiona
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150209/52bbaccc/attachment.html>