[PATCH] SelectionDAG: fold (fp_to_u/sint (u/sint_to_fp val)) when possible

Fiona Glaser fglaser at apple.com
Mon Feb 9 11:48:49 PST 2015


> On Feb 9, 2015, at 11:31 AM, Chandler Carruth <chandlerc at google.com> wrote:
> 
> 
> On Mon, Feb 9, 2015 at 11:30 AM, Fiona Glaser <fglaser at apple.com <mailto:fglaser at apple.com>> wrote:
> I get the message ;-) Already redoing it in instcombine; turns out there’s actually already code for it, but it only triggers when TypeA == TypeB. Will have a patch in a few moments.
> 
> Oh, sorry, I just totally missed Duncan's email. Sorry for the noise!

No problem, thanks for the suggestion. I will eventually figure out the intuition for whether a fold belongs in Instcombine or DAG!

Here’s a new patch that works in instcombine instead.

Fiona

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150209/bc493d37/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: floatcvtfold.diff
Type: application/octet-stream
Size: 4936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150209/bc493d37/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150209/bc493d37/attachment-0001.html>


More information about the llvm-commits mailing list