[PATCH] isDereferenceablePointer: look through gc.relocate calls

Philip Reames listmail at philipreames.com
Mon Feb 9 11:36:51 PST 2015


While your reasoning in the opening comment is faulty, the actual code LGTM.

You can't reason only about what happens when GC doesn't trigger to infer a property of the potentially relocated value.  You need to reason about what happens in both cases: relocation and non-relocation.

Side note (mostly for my own later reference): I could see a theoretically GC like thing which changed dereferenceability on collection, but no practical collector I know of does so.  As such, I don't see a point in controlling this via a flag at this time.


http://reviews.llvm.org/D7454

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list