Looks good to me. I'd prefer using NinjaCommand instead of building a shell command for ninja, but this is not critical for this patch. REPOSITORY rL LLVM http://reviews.llvm.org/D7149 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/