[PATCH] [Mips][Disassembler] Add r6 tables to Mips64Disassembler checks

Daniel Sanders daniel.sanders at imgtec.com
Mon Feb 9 05:29:04 PST 2015


Your change looks good to me but I think there's a better way to resolve this. I think it's wrong for us to have separate Mips32 and Mips64 disassemblers and for the target triple to have an effect on the behaviour (it should be the ELF header rather than the triple). I've uploaded http://reviews.llvm.org/D7498 which folds the two disassembler classes into a single class which I believe does the right thing for Mips32 and Mips64.


http://reviews.llvm.org/D7461

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list