[llvm] r228478 - Support: Fix tests for VirtualityString

Duncan P. N. Exon Smith dexonsmith at apple.com
Fri Feb 6 17:07:31 PST 2015


Author: dexonsmith
Date: Fri Feb  6 19:07:30 2015
New Revision: 228478

URL: http://llvm.org/viewvc/llvm-project?rev=228478&view=rev
Log:
Support: Fix tests for VirtualityString

Since these `dwarf` functions return `const char *`, the tests need to
use `StringRef` for checks.  Should fix, e.g., hexagon [1].

[1]: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22435

Modified:
    llvm/trunk/unittests/Support/DwarfTest.cpp

Modified: llvm/trunk/unittests/Support/DwarfTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/DwarfTest.cpp?rev=228478&r1=228477&r2=228478&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/DwarfTest.cpp (original)
+++ llvm/trunk/unittests/Support/DwarfTest.cpp Fri Feb  6 19:07:30 2015
@@ -96,13 +96,16 @@ TEST(DwarfTest, getAttributeEncoding) {
 }
 
 TEST(DwarfTest, VirtualityString) {
-  EXPECT_EQ("DW_VIRTUALITY_none", VirtualityString(DW_VIRTUALITY_none));
-  EXPECT_EQ("DW_VIRTUALITY_virtual", VirtualityString(DW_VIRTUALITY_virtual));
-  EXPECT_EQ("DW_VIRTUALITY_pure_virtual",
+  EXPECT_EQ(StringRef("DW_VIRTUALITY_none"),
+            VirtualityString(DW_VIRTUALITY_none));
+  EXPECT_EQ(StringRef("DW_VIRTUALITY_virtual"),
+            VirtualityString(DW_VIRTUALITY_virtual));
+  EXPECT_EQ(StringRef("DW_VIRTUALITY_pure_virtual"),
             VirtualityString(DW_VIRTUALITY_pure_virtual));
 
   // DW_VIRTUALITY_max should be pure virtual.
-  EXPECT_EQ("DW_VIRTUALITY_pure_virtual", VirtualityString(DW_VIRTUALITY_max));
+  EXPECT_EQ(StringRef("DW_VIRTUALITY_pure_virtual"),
+            VirtualityString(DW_VIRTUALITY_max));
 
   // Invalid numbers shouldn't be stringified.
   EXPECT_EQ(nullptr, VirtualityString(DW_VIRTUALITY_max + 1));





More information about the llvm-commits mailing list